This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
feat: #20 bootstrap data retrieve endpoint #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 87.56% 87.70% +0.13%
==========================================
Files 6 6
Lines 386 431 +45
==========================================
+ Hits 338 378 +40
- Misses 31 34 +3
- Partials 17 19 +2
Continue to review full report at Codecov.
|
baha-ai
approved these changes
Jul 30, 2020
talwinder50
approved these changes
Jul 30, 2020
DRK3
reviewed
Jul 30, 2020
pkg/restapi/operation/operations.go
Outdated
|
|
||
| if err != nil { | ||
| handleAuthError(w, http.StatusInternalServerError, | ||
| fmt.Sprintf("failed to query transient store for handle : %s", err)) |
There was a problem hiding this comment.
Found one! Extra space before colon
DRK3
reviewed
Jul 30, 2020
pkg/restapi/operation/operations.go
Outdated
| // but edge-core store API doesn't have a Delete() operation: https://github.com/trustbloc/edge-core/issues/45 | ||
| _, err = w.Write(response) | ||
| if err != nil { | ||
| logger.Errorf("failed to write bootstrap data to output : %s", err) |
DRK3
reviewed
Jul 30, 2020
| @@ -340,6 +346,48 @@ func (c *Operation) onboardUser(id string) (*user.Profile, error) { | |||
| return userProfile, nil | |||
| } | |||
|
|
|||
| func (c *Operation) handleBootstrapDataRequest(w http.ResponseWriter, r *http.Request) { | |||
| handle := r.URL.Query().Get("up") | |||
DRK3
reviewed
Jul 30, 2020
| @@ -17,6 +17,8 @@ import ( | |||
| "strings" | |||
| "testing" | |||
|
|
|||
| "github.com/trustbloc/hub-auth/pkg/bootstrap/user" | |||
|
|
|||
DRK3
reviewed
Jul 30, 2020
pkg/restapi/operation/operations.go
Outdated
| KeyStoreIDs: profile.KeyStoreIDs, | ||
| }) | ||
| if err != nil { | ||
| handleAuthError(w, http.StatusInternalServerError, fmt.Sprintf("failed to marshal bootstrap data : %s", err)) |
DRK3
reviewed
Jul 30, 2020
Comment on lines
20
to
22
| "github.com/trustbloc/hub-auth/pkg/bootstrap/user" | ||
|
|
||
| "github.com/trustbloc/hub-auth/pkg/internal/common/mockoidc" |
There was a problem hiding this comment.
These hub-auth imports should be grouped together with the other one
DRK3
reviewed
Jul 30, 2020
| } | ||
|
|
||
| // TODO We should delete the handle from the transient store after writing the response, | ||
| // but edge-core store API doesn't have a Delete() operation: https://github.com/trustbloc/edge-core/issues/45 |
There was a problem hiding this comment.
Let me know if not having the Delete() operation is blocking you and I can work on it
There was a problem hiding this comment.
@DRK3 it's not blocking for now but should be there if we are going to say this thing is "production-ready"
Signed-off-by: George Aristy <[email protected]>
DRK3
approved these changes
Jul 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20
This PR depends on PR #43 where the user's profile is stored to the transient store and the user is redirected to the UI with a handle in the
upquery parameter. This PR reuses that query parameter to fetch the same user bootstrap data.Two new startup parameters were added: SDS URL and Key Server URL.
Signed-off-by: George Aristy [email protected]